fix(controllers) disable more IngressClass lookups

When the IngressClass controller is disabled, disable reconciler lookups to determine if the IngressClass is the default class.
Kong · Jul 19, 2022 · f157998 · f157998
1 parent 4a7d27a
commit f157998
Show file tree

Hide file tree

Showing 2 changed files with 80 additions and 60 deletions.
diff --git a/hack/generators/controllers/networking/main.go b/hack/generators/controllers/networking/main.go
@@ -581,12 +581,14 @@ func (r *{{.PackageAlias}}{{.Kind}}Reconciler) Reconcile(ctx context.Context, re
 	}
 {{if .AcceptsIngressClassNameAnnotation}}
 	class := new(netv1.IngressClass)
-	if err := r.Get(ctx, types.NamespacedName{Name: r.IngressClassName}, class); err != nil {
-		// we log this without taking action to support legacy configurations that only set ingressClassName or
-		// used the class annotation and did not create a corresponding IngressClass. We only need this to determine
-		// if the IngressClass is default or to configure default settings, and can assume no/no additional defaults
-		// if none exists.
-		log.V(util.DebugLevel).Info("could not retrieve IngressClass", "ingressclass", r.IngressClassName)
+	if !r.DisableIngressClassLookups {
+		if err := r.Get(ctx, types.NamespacedName{Name: r.IngressClassName}, class); err != nil {
+			// we log this without taking action to support legacy configurations that only set ingressClassName or
+			// used the class annotation and did not create a corresponding IngressClass. We only need this to determine
+			// if the IngressClass is default or to configure default settings, and can assume no/no additional defaults
+			// if none exists.
+			log.V(util.DebugLevel).Info("could not retrieve IngressClass", "ingressclass", r.IngressClassName)
+		}
 	}
 	// if the object is not configured with our ingress.class, then we need to ensure it's removed from the cache
 	if !ctrlutils.MatchesIngressClass(obj, r.IngressClassName, ctrlutils.IsDefaultIngressClass(class)) {

diff --git a/internal/controllers/configuration/zz_generated_controllers.go b/internal/controllers/configuration/zz_generated_controllers.go