fix: retries can be set to 0 for services in Kong

Kong · Dec 20, 2018 · b8bb7bd · b8bb7bd
1 parent b1a8709
commit b8bb7bd
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/internal/apis/configuration/v1/types.go b/internal/apis/configuration/v1/types.go
@@ -55,7 +55,7 @@ type Proxy struct {
 	Protocol       string `json:"protocol"`
 	Path           string `json:"path"`
 	ConnectTimeout int    `json:"connect_timeout"`
-	Retries        int    `json:"retries"`
+	Retries        *int   `json:"retries"`
 	ReadTimeout    int    `json:"read_timeout"`
 	WriteTimeout   int    `json:"write_timeout"`
 }

diff --git a/internal/apis/configuration/v1/zz_generated.deepcopy.go b/internal/apis/configuration/v1/zz_generated.deepcopy.go
diff --git a/internal/ingress/controller/kong.go b/internal/ingress/controller/kong.go
@@ -391,9 +391,9 @@ func (n *NGINXController) syncServices(ingressCfg *ingress.Configuration) (bool,
 							outOfSync = true
 						}
 
-						if kongIngress.Proxy.Retries > 0 &&
-							(s.Retries == nil || *s.Retries != kongIngress.Proxy.Retries) {
-							s.Retries = kong.Int(kongIngress.Proxy.Retries)
+						if kongIngress.Proxy.Retries != nil &&
+							(s.Retries == nil || s.Retries != kongIngress.Proxy.Retries) {
+							s.Retries = kong.Int(*kongIngress.Proxy.Retries)
 							outOfSync = true
 						}
 					}