-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(upgrade) instructions for 3.0 #9404
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should chat about what will happen if user use a declarative config file from 2.x in 3.0.
The failing test should be unrelated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving this but not merging yet in order to give the docs team some time to review.
@suika-kong could you point this PR to the |
detail for hybrid mode upgrade fix: we should not mention bg mig here rephrase Apply suggestions from code review Co-authored-by: Makito <sumimakito@hotmail.com> Co-authored-by: Datong Sun <datong.sun@konghq.com> add example for expected log docs(upgrade) Update from docs.konghq.com copy editing Signed-off-by: Tyler Ball <tyler.ball@konghq.com>
* Correcting information about blue-green deploys from 2.8 to 3.0 For EE, users will need to update to 2.8.1.5 before trying a blue-green upgrade to 3.0.0.0 Signed-off-by: Tyler Ball <tyler.ball@konghq.com> * style: Update app/gateway/changelog.md Add missing comma Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com> * style: better grammar Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com> * style: add missing comma Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com> * Correct statements of blue-green deploys (#4409) 1. OSS also support bg migration for hybrid mode; 2. Instruction and explanation of the migrations process * typo fix * Formatting & language * better formatting for blue-green section in upgrade guide * Attempting to clarify our support upgrade strategies and topologies Signed-off-by: Tyler Ball <tyler.ball@konghq.com> * follow the change of Kong/kong/pull/9404 * Formatting, grammar * fix duplicate info in changelog * add callout for blue-green to top of guide * traditional mode * better grammar Signed-off-by: Tyler Ball <tyler.ball@konghq.com> Co-authored-by: Hans Hübner <hans.huebner@gmail.com> Co-authored-by: lena-larionova <54370747+lena-larionova@users.noreply.github.com> Co-authored-by: Xumin <100666470+Suika-Kong@users.noreply.github.com> Co-authored-by: suika-kong <xumin.zhou@konghq.com> Co-authored-by: lena.larionova <yelena.larionova@gmail.com>
1b52d02
to
4aa6164
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just want to emphasize again the importance of consistency, we can not have "data store" and "datastore" mixed in the same document. Also, pay attention to the capitalization of well defined Kong specific terms like "Control Plane" instead of "control plane".
I also want to emphasize the importance of explaining what we are doing in each of the steps, in order to educate the user who might not be familiar with what each command does.
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Co-authored-by: Datong Sun <datong.sun@konghq.com>
Dismissing this review, changes were accepted by Xumin and merged.
Co-authored-by: Makito <sumimakito@hotmail.com> Co-authored-by: Datong Sun <datong.sun@konghq.com>
We support 3 ways to migrate to 3.0 with no downtime:
up
andfinish
;The first 1 requires 2.8.2, the second 1 requires 2.8.x, and the last one support any version that can be migrated with
migrations up
.