Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests(helpers): separate cmd&pid functions #13648

Merged
merged 13 commits into from
Sep 13, 2024
Merged

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Sep 11, 2024

Summary

KAG-5244

Move echo server related functions since they are using cmd.stop_kong()

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

Fix #[issue number]

@github-actions github-actions bot added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Sep 11, 2024
@chronolaw chronolaw marked this pull request as ready for review September 11, 2024 08:40
@StarlightIbuki
Copy link
Contributor

I suppose we will also update the user of those utilities to directly import from separated files, to avoid unnecessary dependencies?

@chronolaw
Copy link
Contributor Author

I suppose we will also update the user of those utilities to directly import from separated files, to avoid unnecessary dependencies?

It may cause incompatible issues, currently we will not change the interface of helpers.

@windmgc windmgc merged commit 2c4a0b6 into master Sep 13, 2024
25 checks passed
@windmgc windmgc deleted the tests/clean_helper_cmd branch September 13, 2024 02:45
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13648-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13648-to-master-to-upstream
git checkout -b cherry-pick-13648-to-master-to-upstream
ancref=$(git merge-base c498f41dc03f7a04aaf3df24c59e01ff5e39c339 3bd7ce5b076eee1f3658187864998c3c53f1dafc)
git cherry-pick -x $ancref..3bd7ce5b076eee1f3658187864998c3c53f1dafc

@github-actions github-actions bot added the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 13, 2024
@AndyZhang0707 AndyZhang0707 removed the incomplete-cherry-pick A cherry-pick was incomplete and needs manual intervention label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee size/XXL skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants