Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backport -> release/3.8.x] fix(vault): let shdict secret vault cache presist enough time during resurrect_ttl #13561

Merged
merged 1 commit into from
Aug 23, 2024

Commits on Aug 23, 2024

  1. fix(vault): let shdict secret vault cache presist enough time during …

    …resurrect_ttl (#13471)
    
    This PR fixes an issue that rotate_secret may flush a secret value with NEGATIVE_CACHED_VALUE when vault backend is down and a secret value stored in the shared dict has passed its ttl and hasn't finished consuming its resurrect_ttl.
    
    TLDR; this issue happens easily when a reference is being used via the vault PDK function in custom codes(serverless functions, custom plugins, etc.), and some of the worker processes may not be triggered via the service/routes that use these custom codes, and these worker processes do not hold a valid LRU cache for the secret value
    
    The issue was first reported in FTI-6137.
    
    ---------
    
    Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
    Co-authored-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
    (cherry picked from commit 9269195)
    windmgc authored and github-actions[bot] committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    135ef8a View commit details
    Browse the repository at this point in the history