Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wasm): re-enable Lua DNS resolver for proxy-wasm #13424

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

flrgh
Copy link
Contributor

@flrgh flrgh commented Jul 25, 2024

Summary

This was previously disabled in 9a5d48b (#12825) due to shortcomings of the underlying ngx_wasm_module Lua execution model, which has since been fixed and merged into master (19ee6a9).

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com

Issue reference

KAG-4671

Replace #13363 (can't re-open this PR after force-pushing the branch)

@flrgh flrgh requested review from brentos and locao July 25, 2024 01:06
@github-actions github-actions bot added core/configuration cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Jul 25, 2024
@locao locao merged commit aa5263c into master Jul 25, 2024
34 checks passed
@locao locao deleted the fix/enable-proxy-wasm-lua-dns-resolver branch July 25, 2024 15:20
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/configuration size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants