Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): add ngx_brotli module #12367

Merged
merged 10 commits into from
Jan 19, 2024
Merged

feat(core): add ngx_brotli module #12367

merged 10 commits into from
Jan 19, 2024

Conversation

oowl
Copy link
Member

@oowl oowl commented Jan 18, 2024

Summary

add ngx_brotli module to Kong prebuilt Nginx binary. So we can use these configs in kong configure to support brotli compression feature in Kong.

nginx_proxy_brotli = "on"
nginx_proxy_brotli_comp_level = 6
nginx_proxy_brotli_types = "text/plain text/css application/json application/x-javascript text/xml application/xml application/xml+rss text/javascript application/javascript text/x-js"

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-2477

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jan 18, 2024
@oowl oowl added this to the 3.6.0 milestone Jan 18, 2024
@locao
Copy link
Contributor

locao commented Jan 18, 2024

Is (or will be) there a sister PR for the docs repo?

@oowl oowl requested a review from chobits January 19, 2024 01:40
@oowl
Copy link
Member Author

oowl commented Jan 19, 2024

Is (or will be) there a sister PR for the docs repo?

Where can I add brotli compress feature doc? It seems our doc has not described anything related to the nginx inject Nginx Directives list. https://docs.konghq.com/gateway/latest/reference/nginx-directives/

@windmgc windmgc requested a review from fffonion January 19, 2024 05:39
@windmgc
Copy link
Member

windmgc commented Jan 19, 2024

Could you run a full matrix test build to verify the manifests are all correct? Like the one here #11629 (comment)

@oowl
Copy link
Member Author

oowl commented Jan 19, 2024

Could you run a full matrix test build to verify the manifests are all correct? Like the one here #11629 (comment)

https://github.com/Kong/kong/actions/runs/7579992609

@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Jan 19, 2024
.requirements Show resolved Hide resolved
@oowl
Copy link
Member Author

oowl commented Jan 19, 2024

compiler ld failed in the master branch, So I switched to the google rc version. https://github.com/Kong/kong/actions/runs/7580586355/job/20646664578#step:18:1891

@oowl
Copy link
Member Author

oowl commented Jan 19, 2024

All matrix test has been passed, So I revert ae1564c

@fffonion fffonion merged commit 25851ba into master Jan 19, 2024
24 checks passed
@fffonion fffonion deleted the feat/brotli branch January 19, 2024 09:17
@oowl oowl added the cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee label Jan 20, 2024
@team-gateway-bot
Copy link
Collaborator

Cherry-pick failed for master, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally.

git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-12367-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-12367-to-master-to-upstream
git checkout -b cherry-pick-12367-to-master-to-upstream
ancref=$(git merge-base f0ba93044a73ab3d4191367e2fcac76fa0d06b7e 16e8742e01eafbcc21313aa66920465de3a8f83c)
git cherry-pick -x $ancref..16e8742e01eafbcc21313aa66920465de3a8f83c

@locao
Copy link
Contributor

locao commented Jan 22, 2024

Where can I add brotli compress feature doc? It seems our doc has not described anything related to the nginx inject Nginx Directives list. https://docs.konghq.com/gateway/latest/reference/nginx-directives/

It seems you are right, we don't have these features documented anywhere.

I got late to the party, but LGTM 😄🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee chore Not part of the core functionality of kong, but still needed size/L
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants