Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tracing): per request debugging #11627

Merged
merged 16 commits into from
Sep 27, 2023
Merged

feat(tracing): per request debugging #11627

merged 16 commits into from
Sep 27, 2023

Conversation

ADD-SP
Copy link
Contributor

@ADD-SP ADD-SP commented Sep 21, 2023 •
edited
Loading

Summary

A mechanism for observing the time consumed by each component (not all) of the given request.

Checklist

  • The Pull Request has tests
  • A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md
  • [N/A] There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

KAG-1902

@ADD-SP ADD-SP force-pushed the add_sp/feat-req-dbg branch 2 times, most recently from 8058d3b to 5d88a96 Compare September 21, 2023 09:14
@ADD-SP ADD-SP marked this pull request as ready for review September 21, 2023 10:05
@ADD-SP ADD-SP requested a review from dndx September 21, 2023 10:05
@ADD-SP ADD-SP force-pushed the add_sp/feat-req-dbg branch 2 times, most recently from fa8565a to 171f562 Compare September 22, 2023 02:45
chronolaw
chronolaw reviewed Sep 22, 2023
View reviewed changes
kong/constants.lua Outdated Show resolved Hide resolved
kong/hooks.lua Show resolved Hide resolved
chronolaw
chronolaw reviewed Sep 22, 2023
View reviewed changes
kong/timing/context.lua Outdated Show resolved Hide resolved
kong/timing/hooks/dns.lua Outdated Show resolved Hide resolved
@chronolaw
Copy link
Contributor

Need a change log YAML file.

chronolaw
chronolaw reviewed Sep 22, 2023
View reviewed changes
kong/dynamic_hook/init.lua Show resolved Hide resolved
kong/dynamic_hook/init.lua Outdated Show resolved Hide resolved
kong/dynamic_hook/init.lua Outdated Show resolved Hide resolved
@ADD-SP ADD-SP force-pushed the add_sp/feat-req-dbg branch 4 times, most recently from 12b1581 to 4160489 Compare September 22, 2023 06:09
chronolaw
chronolaw reviewed Sep 22, 2023
View reviewed changes
CHANGELOG/unreleased/kong/11627.yaml Outdated Show resolved Hide resolved
kong/timing/init.lua Outdated Show resolved Hide resolved
@ADD-SP ADD-SP force-pushed the add_sp/feat-req-dbg branch from 1130a6a to 5432949 Compare September 22, 2023 06:23
chronolaw
chronolaw reviewed Sep 22, 2023
View reviewed changes
kong/timing/context.lua Outdated Show resolved Hide resolved
kong/timing/hooks/http.lua Outdated Show resolved Hide resolved
kong/timing/hooks/http.lua Show resolved Hide resolved
kong/timing/hooks/http.lua Show resolved Hide resolved
kong/timing/hooks/socket.lua Outdated Show resolved Hide resolved
kong/timing/hooks/socket.lua Outdated Show resolved Hide resolved
chronolaw
chronolaw reviewed Sep 25, 2023
View reviewed changes
kong/timing/context.lua Outdated Show resolved Hide resolved
kong/timing/hooks/dns.lua Show resolved Hide resolved
kong/timing/init.lua Outdated Show resolved Hide resolved
@ADD-SP ADD-SP force-pushed the add_sp/feat-req-dbg branch from 84ad72e to 6f06153 Compare September 25, 2023 02:55
@chobits chobits self-requested a review September 25, 2023 03:20
@ADD-SP ADD-SP requested review from chobits and chronolaw September 25, 2023 05:27
@ADD-SP ADD-SP force-pushed the add_sp/feat-req-dbg branch from 373167f to 8dea62c Compare September 27, 2023 04:59
dndx
dndx reviewed Sep 27, 2023
View reviewed changes
kong/dynamic_hook/init.lua Show resolved Hide resolved
kong/init.lua Outdated Show resolved Hide resolved
@ADD-SP ADD-SP force-pushed the add_sp/feat-req-dbg branch from 8dea62c to 90ef04c Compare September 27, 2023 08:14
dndx
dndx reviewed Sep 27, 2023
View reviewed changes
kong/timing/init.lua Outdated Show resolved Hide resolved
dndx
dndx reviewed Sep 27, 2023
View reviewed changes
kong/init.lua Outdated Show resolved Hide resolved
@ADD-SP ADD-SP force-pushed the add_sp/feat-req-dbg branch 2 times, most recently from dc77284 to d9a7236 Compare September 27, 2023 09:01
@ADD-SP ADD-SP force-pushed the add_sp/feat-req-dbg branch from d9a7236 to 1871411 Compare September 27, 2023 09:02
@dndx dndx merged commit 3c7b63b into master Sep 27, 2023
23 checks passed
@dndx dndx deleted the add_sp/feat-req-dbg branch September 27, 2023 13:14
@chronolaw chronolaw mentioned this pull request Sep 28, 2023
Merged
3 tasks
@ADD-SP ADD-SP mentioned this pull request Dec 25, 2023
Merged
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chronolaw chronolaw chronolaw approved these changes

@dndx dndx dndx approved these changes

@chobits chobits chobits approved these changes

Assignees

@ADD-SP ADD-SP

Labels
core/configuration core/proxy core/templates size/XXL
Projects
None yet
Milestone
3.5.0
Development

Successfully merging this pull request may close these issues.
5 participants
@ADD-SP @chronolaw @chobits @dndx @team-eng-enablement