chore(clustering/db): reduce log flooding on clustering and schema validation #11124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidation ### Summary On control plane there was a debug log written on every second on every worker that had no connected clients. This will now only log it once per worker, until number of connected clients changes. The schema validation also had a thing called unvalidated fields that caused huge amounts of logs to be written with large config import / validation. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
bungle
force-pushed
the
chore/log-flooding
branch
from
f614b51
to
c24746f
Compare
| kong.log.debug("ignoring validation on ", k, " field") | ||
| else | ||
|
|
||
| elseif not self.unvalidated_fields[k]() then |
There was a problem hiding this comment.
LGTM, the logs for the unvalidated fields don't seem that useful at present.
liverpool8056
approved these changes
Jun 27, 2023
bungle
added a commit
that referenced
this pull request
Jun 27, 2023
…goto" ### Summary Follow-up from #11124 to slightly clean the code. Signed-off-by: Aapo Talvensaari <aapo.talvensaari@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On control plane there was a debug log written on every second on every worker that had no connected clients. This will now only log it once per worker, until number of connected clients changes.
The schema validation also had a thing called unvalidated fields that caused huge amounts of logs to be written with large config import / validation. (I didn't count but with my example config I got thousands, perhaps tens of thousands of log lines on same second with exactly same uninformal message
2023/06/26 20:08:36 [debug] 72011#0: *10 [kong] init.lua:1121 ignoring validation on updated_at field).