Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(plugin/prometheus): remove the usage of string.gsub and ipairs #11113

Merged
merged 7 commits into from
Jun 27, 2023
Merged

perf(plugin/prometheus): remove the usage of string.gsub and ipairs #11113

merged 7 commits into from
Jun 27, 2023

Conversation

chronolaw
Copy link
Contributor

@chronolaw chronolaw commented Jun 25, 2023 •
edited
Loading

Summary

Import some changes from knyar/nginx-lua-prometheus#131.

Checklist

Full changelog

  • [Implement ...]

Issue reference

Fix #[issue number]

@pull-request-size pull-request-size bot added size/M and removed size/S labels Jun 25, 2023
@chronolaw chronolaw requested a review from oowl June 26, 2023 07:21
sabertobihwy
sabertobihwy approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

@sabertobihwy sabertobihwy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

oowl
oowl approved these changes Jun 26, 2023
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@windmgc windmgc merged commit 6bfffc8 into master Jun 27, 2023
20 checks passed
@windmgc windmgc deleted the perf/import_improvments_from_upstream_repo branch June 27, 2023 03:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oowl oowl oowl approved these changes

@sabertobihwy sabertobihwy sabertobihwy approved these changes

Assignees

@chronolaw chronolaw

Labels
plugins/prometheus size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chronolaw @oowl @sabertobihwy @windmgc