chore(ci): add wasm to release builds #11039
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
build/bazel
chore
flrgh
force-pushed
the
chore/ci-wasm-releases
branch
2 times, most recently
from
5162537
to
9bd5881
Compare
flrgh
force-pushed
the
chore/ci-wasm-releases
branch
from
1c3f5fd
to
a6317f4
Compare
flrgh
force-pushed
the
chore/ci-wasm-releases
branch
from
a6317f4
to
cbb59e6
Compare
flrgh
changed the title
flrgh
commented
Jun 28, 2023
| @@ -197,6 +234,12 @@ CONFIGURE_OPTIONS = [ | |||
| }) + select({ | |||
| "@kong//:wasmx_flag": [ | |||
| "--add-module=$$EXT_BUILD_ROOT$$/external/ngx_wasm_module", | |||
| # this is a workaround for rhel/centos builds | |||
There was a problem hiding this comment.
FYI: @curiositycasualty @fffonion
I don't know enough to judge the level of risk/impact of this change. If necessary I'm sure it could be limited to just centos/rhel-based builds, but I opted to start with the simple approach for now.
Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
locao
approved these changes
Jun 30, 2023
the commented line breaks the build for macos, probably the flag is not supported by clang
locao
approved these changes
Jun 30, 2023
locao
added a commit
that referenced
this pull request
Jul 13, 2023
* chore(ci): add wasm to release builds * chore(*): apply review suggestions Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com> * chore(*): apply review suggestions Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com> * chore(*): apply review suggestions Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com> * chore(build): change the v8 runtime URL * chore(build): workaround for macos the commented line breaks the build for macos, probably the flag is not supported by clang --------- Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
locao
added a commit
that referenced
this pull request
Jul 14, 2023
* chore(ci): add wasm to release builds * chore(*): apply review suggestions Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com> * chore(*): apply review suggestions Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com> * chore(*): apply review suggestions Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com> * chore(build): change the v8 runtime URL * chore(build): workaround for macos the commented line breaks the build for macos, probably the flag is not supported by clang --------- Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
flrgh
added a commit
that referenced
this pull request
Jul 17, 2023
* chore(ci): add wasm to release builds * chore(*): apply review suggestions Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com> * chore(*): apply review suggestions Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com> * chore(*): apply review suggestions Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com> * chore(build): change the v8 runtime URL * chore(build): workaround for macos the commented line breaks the build for macos, probably the flag is not supported by clang --------- Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This turns on
ngx_wasm_moduleby default, adding it to all of our amd64 builds in the release workflow.Right now we only build and package with
wasmtime, because that is what is planned to ship, but there is partial support for wasmer and v8 in here as well, should we decide to make them available in the future.Additionally, with this change the wasm runtime is now statically linked to
ngx_wasm_module, so there are fewer shared object files that need to be copied around into our common lib directory at build time.