fix(grpc): empty message cannot be unframed #10836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StarlightIbuki
commented
May 10, 2023
chronolaw
approved these changes
May 10, 2023
I guess not. This one is not that critical (in rare cases people send empty messages), and we're already releasing 3.3. |
Fix FTI-5054 Update CHANGELOG.md
StarlightIbuki
force-pushed
the
fix/grpc-empty-message
branch
from
1cff820 to
804fb15
Compare
bungle
approved these changes
May 12, 2023
3 tasks
windmgc
pushed a commit
that referenced
this pull request
May 23, 2023
lhanjian
pushed a commit
that referenced
this pull request
Dec 23, 2024
* fix(active-tracing): add global configuration switch * Apply suggestions from code review Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com> --------- Co-authored-by: Vinicius Mignot <vinicius.mignot@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We found an issue when testing the fix of #10801. When a service responds with a message with all default value fields, the JSON response would be totally empty.
The reason for this issue is that we assume a message to be at least of length 1 when unframing.
Removing this restriction (a message can be of length 0) fixes this issue.
Checklist
There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HEREIssue reference
Fix FTI-5054
Fix #10802