tests(integration): add missing /status api tests #10629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pluveto
changed the title
pluveto
changed the title
|
@shaneutt The test seems not working. Can you help us? |
locao
force-pushed
the
bug/tests_not_running
branch
from
6cd716a
to
ca77020
Compare
locao
force-pushed
the
bug/tests_not_running
branch
from
8722872
to
508a548
Compare
locao
changed the title
locao
force-pushed
the
bug/tests_not_running
branch
from
508a548
to
c36022a
Compare
locao
force-pushed
the
bug/tests_not_running
branch
from
c36022a
to
4d827cd
Compare
locao
force-pushed
the
bug/tests_not_running
branch
from
182cc11
to
1bb9850
Compare
|
@gszr pinging you as the tests were updated and this PR is converted from draft to ready to review. |
gszr
approved these changes
Apr 17, 2023
|
Waiting on CI 💚 |
outsinre
added a commit
that referenced
this pull request
May 8, 2023
Previously, CE #10629 has some code refactoring to status api test. However, there are two pitfalls. 1. Some of the refactoring is uncessary. 2. The author intern was back to school, and did not finish his cherry-pick. This PR make sure the api status test on CE and EE sync.
3 tasks
windmgc
pushed a commit
that referenced
this pull request
May 9, 2023
* tests(status-api): make sure status api test sync on CE and EE Previously, CE #10629 has some code refactoring to status api test. However, due to some pitfalls the PR cannot continue to progress so we make another PR to get the tests synced between CE and EE. This PR make sure the api status test on CE and EE sync.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
#8214 added
configuration_hashin/statusfor dbless mode. It had tests, but they were never executed in CI as they were not added torun_tests.sh.This change adds the #8214 tests to the test suite and fixes some broken tests.
Related commit:
4f8c99d
Checklist
Full changelog
spec/02-integration/08-status_api/01-core_routes_spec.luaspec/02-integration/08-status_api/01-core_routes_spec.luaandspec/02-integration/11-dblessto the test suite.Issue reference
Fix KAG-1135