Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wasm): disable Lua DNS resolver for proxy-wasm #12825

Merged
merged 1 commit into from
Apr 23, 2024
Merged

fix(wasm): disable Lua DNS resolver for proxy-wasm #12825

merged 1 commit into from
Apr 23, 2024

Conversation

hishamhm
Copy link
Contributor

@hishamhm hishamhm commented Apr 3, 2024 •
edited by locao
Loading

Summary

We need to disable this for the time being, as coroutine scheduling issues in the Wasm/Lua bridge are addressed in ngx_wasmx_module.

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com

Issue reference

@github-actions github-actions bot added core/configuration cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee labels Apr 3, 2024
@hishamhm hishamhm force-pushed the fix/wasm-disable-pwm-lua-resolver branch 2 times, most recently from 30d5d90 to a78036c Compare April 3, 2024 21:08
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Apr 3, 2024
@flrgh flrgh self-requested a review April 4, 2024 00:27
@hishamhm hishamhm force-pushed the fix/wasm-disable-pwm-lua-resolver branch from a78036c to 3741e0f Compare April 5, 2024 02:13
@hishamhm hishamhm marked this pull request as ready for review April 17, 2024 14:49
@flrgh flrgh added this to the 3.7.0 milestone Apr 18, 2024
@hishamhm @locao
fix(wasm): disable Lua DNS resolver for proxy-wasm
294fffd 
We need to disable this for the time being, as coroutine scheduling
issues in the Wasm/Lua bridge are addressed in ngx_wasmx_module.
@locao locao force-pushed the fix/wasm-disable-pwm-lua-resolver branch from 3741e0f to 294fffd Compare April 23, 2024 13:13
@kikito kikito merged commit 9a5d48b into master Apr 23, 2024
25 checks passed
@kikito kikito deleted the fix/wasm-disable-pwm-lua-resolver branch April 23, 2024 13:33
@team-gateway-bot
Copy link
Collaborator

Successfully created cherry-pick PR for master:

locao pushed a commit that referenced this pull request Apr 24, 2024
@team-gateway-bot @hishamhm
fix(wasm): disable Lua DNS resolver for proxy-wasm (#12825) (#8899)
b84d016 
We need to disable this for the time being, as coroutine scheduling
issues in the Wasm/Lua bridge are addressed in ngx_wasmx_module.

(cherry picked from commit 9a5d48b)

Co-authored-by: Hisham Muhammad <hisham@gobolinux.org>
@flrgh flrgh mentioned this pull request Jul 11, 2024
Closed
3 tasks
@flrgh flrgh mentioned this pull request Jul 25, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@locao locao locao approved these changes

@flrgh flrgh flrgh approved these changes

Assignees

@hishamhm hishamhm

Labels
cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee core/configuration size/S
Projects
None yet
Milestone
3.7.0
Development

Successfully merging this pull request may close these issues.
5 participants
@hishamhm @team-gateway-bot @flrgh @locao @kikito