fix(pluginsocket.proto): type for set_upstream

Fix the return type for the `.Service.SetUpstream` external plugin PDK method. Fixes issue Kong/go-pdk#114. Sister PR: Kong/go-pdk#191
Kong · Mar 13, 2024 · 25b3317 · 25b3317 · github-actions · Mar 13, 2024
1 parent cea6f24
commit 25b3317
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 1 deletion.
diff --git a/changelog/unreleased/kong/pluginsocket-proto-wrong-type.yml b/changelog/unreleased/kong/pluginsocket-proto-wrong-type.yml
@@ -0,0 +1,3 @@
+message: |
+  Fix an issue where external plugins using the protobuf-based protocol would fail to call the `kong.Service.SetUpstream` method with an error `bad argument #2 to 'encode' (table expected, got boolean)`.
+type: bugfix
diff --git a/kong/include/kong/pluginsocket.proto b/kong/include/kong/pluginsocket.proto
@@ -328,7 +328,7 @@ service Kong {
     rpc Router_GetRoute(google.protobuf.Empty) returns (Route);
     rpc Router_GetService(google.protobuf.Empty) returns (Service);
 
-    rpc Service_SetUpstream(String) returns (google.protobuf.Empty);
+    rpc Service_SetUpstream(String) returns (Bool);
     rpc Service_SetTarget(Target) returns (google.protobuf.Empty);
 
     rpc Service_Request_SetScheme(String) returns (google.protobuf.Empty);