Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow building pongo image from specially tagged test image #348

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hanshuebner
Copy link
Contributor

This change adds the possibility to specify a temporary test image as KONG_IMAGE, similar to using the 'dev' and 'dev-ee' pseudo versions. The image name contains the git tag from which it was built. The added logic will determine KONG_VERSION and whether we're dealing with CE or EE from the image name

This change adds the possibility to specify a temporary test image
as KONG_IMAGE, similar to using the 'dev' and 'dev-ee' pseudo versions.
The image name contains the git tag from which it was built.  The
added logic will determine KONG_VERSION and whether we're dealing
with CE or EE from the image name
@fffonion
Copy link
Contributor

fffonion commented Mar 2, 2023

@hanshuebner i was working on running pongo with current commit of build and found this PR might be related. is this PR still we want to persue? if so could you describe what's left/what's not working so i can pick up?

@hanshuebner
Copy link
Contributor Author

@fffonion If I remember right, this was pretty much working but nobody except myself tested it and it was basically forgotten. I have no plans working on it, but feel free to involve me if there is anything I can help with to get it merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants