Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add async task indicator [INS-4106] #7522

Merged
merged 2 commits into from
Jul 16, 2024

Conversation

CurryYangxx
Copy link
Member

@CurryYangxx CurryYangxx commented Jun 11, 2024

Add indicator to display async task status

  • indicator UI, display status for 3 types of status
    only keep one indicator for 'online/offline' and async task status.When syncing, the 'online' transfer to 'syncing', and if success, turn back 'online'
  • click to retry
image image

related to #7492

@CurryYangxx CurryYangxx marked this pull request as draft June 11, 2024 08:50
@CurryYangxx CurryYangxx marked this pull request as ready for review June 11, 2024 10:11
@CurryYangxx CurryYangxx requested a review from a team June 11, 2024 10:11
@CurryYangxx CurryYangxx changed the title feat: add async task indicator feat: add async task indicator [INS-3957] Jun 20, 2024
@CurryYangxx CurryYangxx marked this pull request as draft June 20, 2024 11:25
@CurryYangxx CurryYangxx changed the base branch from perf/modify-initial-entry to release-performance-improvement June 21, 2024 06:24
@CurryYangxx CurryYangxx changed the base branch from release-performance-improvement to develop June 24, 2024 03:30
@CurryYangxx CurryYangxx changed the title feat: add async task indicator [INS-3957] feat: add async task indicator [INS-4106] Jul 2, 2024
@CurryYangxx CurryYangxx force-pushed the feat/add-sync-task-indicator branch 3 times, most recently from 09fe59a to 0b88585 Compare July 12, 2024 06:59
@CurryYangxx CurryYangxx self-assigned this Jul 12, 2024
ihexxa
ihexxa previously approved these changes Jul 12, 2024
organizationId,
asyncTaskList,
}, {
action: '/organization/syncOrgsAndProjectsAction',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: probably we could use /organization/sync-orgs-and-projects-action

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea. Updated

@CurryYangxx CurryYangxx force-pushed the feat/add-sync-task-indicator branch 2 times, most recently from 74af9aa to 75b946b Compare July 15, 2024 09:57
@CurryYangxx CurryYangxx requested a review from ihexxa July 15, 2024 09:57
ihexxa
ihexxa previously approved these changes Jul 16, 2024
@CurryYangxx CurryYangxx force-pushed the feat/add-sync-task-indicator branch from 75b946b to 1bab903 Compare July 16, 2024 02:21
@CurryYangxx CurryYangxx marked this pull request as ready for review July 16, 2024 02:21
@CurryYangxx CurryYangxx requested a review from ihexxa July 16, 2024 02:34
@CurryYangxx CurryYangxx merged commit 9d99080 into develop Jul 16, 2024
8 checks passed
@CurryYangxx CurryYangxx deleted the feat/add-sync-task-indicator branch July 16, 2024 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants