Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integrate post-request script to the engine - INS-3785,INS-3786 #7329

Merged
merged 10 commits into from
May 15, 2024
Merged

feat: integrate post-request script to the engine - INS-3785,INS-3786 #7329

merged 10 commits into from
May 15, 2024

Conversation

ihexxa
Copy link
Contributor

@ihexxa ihexxa commented Apr 28, 2024 •
edited
Loading

Background

Integrating the post-request script to the engine, will start another pr for renaming related functions and variables.

Changes:

@ihexxa ihexxa self-assigned this Apr 28, 2024
@ihexxa ihexxa marked this pull request as draft April 28, 2024 07:18
@ihexxa ihexxa changed the title wip - feat: integrate post-request script to the engine wip - feat: integrate post-request script to the engine - INS-3785,INS-3786 Apr 28, 2024
@ihexxa ihexxa force-pushed the post-script-integration branch from 76ba136 to ab97c3b Compare April 29, 2024 05:59
@ihexxa ihexxa changed the title wip - feat: integrate post-request script to the engine - INS-3785,INS-3786 feat: integrate post-request script to the engine - INS-3785,INS-3786 Apr 29, 2024
@ihexxa ihexxa marked this pull request as ready for review April 29, 2024 06:17
@ihexxa ihexxa requested a review from a team April 29, 2024 06:17
@ihexxa ihexxa force-pushed the post-script-integration branch from ffc5a1b to b78828a Compare May 14, 2024 04:50
ihexxa added 3 commits May 14, 2024 14:55
@ihexxa
fix: the error message is updated
c51e364
@ihexxa
feat: add snippets for post-request scripting (#7395)
8eb5a01
@ihexxa
feat: enable extended assertion chains on insomnia.response (#7396)
e81550e 
* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error
@ihexxa ihexxa merged commit ce8e0c4 into feature-post-request-script May 15, 2024
7 checks passed
@ihexxa ihexxa deleted the post-script-integration branch May 15, 2024 02:30
@ihexxa ihexxa mentioned this pull request May 15, 2024
Merged
ihexxa added a commit that referenced this pull request May 15, 2024
@ihexxa @jackkav
feat: integrate post-request script to the engine - INS-3785,INS-3786 (…
97a6888 
…#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>
ihexxa added a commit that referenced this pull request May 20, 2024
@ihexxa @jackkav
feat: integrate post-request script to the engine - INS-3785,INS-3786 (…
86ca899 
…#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>
ihexxa added a commit that referenced this pull request May 22, 2024
@ihexxa @jackkav
feat: integrate post-request script to the engine - INS-3785,INS-3786 (…
a3ebf95 
…#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>
jackkav added a commit that referenced this pull request May 22, 2024
@ihexxa @jackkav
feat: integrate post-request script to the engine - INS-3785,INS-3786 (…
301a9d1 
…#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>
ihexxa added a commit that referenced this pull request May 23, 2024
@ihexxa @jackkav
feat: enable major features of the after-response script (#7411)
46b6ea8 
* feat: update data model and request-pane to support post-req-script

* fix: unit test failed

* feat: integrate post-request script to the engine - INS-3785,INS-3786 (#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (#7395)

* feat: enable extended assertion chains on `insomnia.response` (#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>

* test: add tests for post-request scripts and post-request scripts - INS-3786 (#7331)

* test: add some tests for post-req script and script engine

* fix: incorrect script type

* chore: refresh package-lock after merging

* chore: clean up package-lock.json

* fix: failed tests after rebasing

* feat: support importing post-req script from Postman (#7423)

* feat: support importing post-req script from Postman

* fix: introduce post-req script property for merged changes

* test: add a test case for importing scripts

* fix: add missing fixture

* chore: remove row after merging

* chore: rename to after-response-script

* fix test

* refresh lock

* update snapshot

* extract pre request logic to function

* refresh lock again

* throw on base env

* fix: revert the logic which rejects the case of unselected environment

---------

Co-authored-by: jackkav <jackkav@gmail.com>
stefancruz pushed a commit to stefancruz/insomnia that referenced this pull request Jun 30, 2024
@ihexxa @jackkav @stefancruz
feat: enable major features of the after-response script (Kong#7411)
28b5e31 
* feat: update data model and request-pane to support post-req-script

* fix: unit test failed

* feat: integrate post-request script to the engine - INS-3785,INS-3786 (Kong#7329)

* feat: integrate post-request script to the engine

* refactor: some minor improvements

* fix: lint error

* chore: clean up typings

* refactor: separate transforming into sync and async parts

* use named args

* fix: renaming pre-req vars, functions and 2 minor fixes

* fix: the error message is updated

* feat: add snippets for post-request scripting (Kong#7395)

* feat: enable extended assertion chains on `insomnia.response` (Kong#7396)

* feat: add snippets for post-request scripting

* feat(sdk): support response.to.have assertion for verifying response

* chore: fix lint error

---------

Co-authored-by: jackkav <jackkav@gmail.com>

* test: add tests for post-request scripts and post-request scripts - INS-3786 (Kong#7331)

* test: add some tests for post-req script and script engine

* fix: incorrect script type

* chore: refresh package-lock after merging

* chore: clean up package-lock.json

* fix: failed tests after rebasing

* feat: support importing post-req script from Postman (Kong#7423)

* feat: support importing post-req script from Postman

* fix: introduce post-req script property for merged changes

* test: add a test case for importing scripts

* fix: add missing fixture

* chore: remove row after merging

* chore: rename to after-response-script

* fix test

* refresh lock

* update snapshot

* extract pre request logic to function

* refresh lock again

* throw on base env

* fix: revert the logic which rejects the case of unselected environment

---------

Co-authored-by: jackkav <jackkav@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkav jackkav jackkav left review comments

@filfreire filfreire filfreire approved these changes

Assignees

@ihexxa ihexxa

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ihexxa @jackkav @filfreire