Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip healthcheck #168

Merged
merged 3 commits into from
Apr 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/test.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@ jobs:
with:
node-version: 21
- run: npm ci
- uses: biomejs/setup-biome@v1
- uses: biomejs/setup-biome@v2
- run: biome ci .
- run: npm test
2 changes: 1 addition & 1 deletion lib/middleware/body-parser.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const Dicer = require("dicer");
const querystring = require("querystring");
const querystring = require("node:querystring");
const contentTypeParser = require("content-type");
const util = require("../utils");

Expand Down
2 changes: 1 addition & 1 deletion lib/middleware/negotiate-content.js
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ module.exports = (req, res, next) => {

// am I pretty?
const spaces = req.headers["x-pretty-print"]
? parseInt(req.headers["x-pretty-print"], 10)
? Number.parseInt(req.headers["x-pretty-print"], 10)
: 2;

const xmlOpts = {
Expand Down
2 changes: 1 addition & 1 deletion lib/routes/bins.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ const express = require("express");
const mw = require("../middleware");
const { createClient } = require("redis");
const routes = require("./bins/");
const URL = require("url").URL;
const URL = require("node:url").URL;

module.exports = function bins(dsnStr) {
// parse redis dsn
Expand Down
2 changes: 1 addition & 1 deletion lib/routes/bins/create.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const debug = require("debug")("mockbin");
const util = require("util");
const util = require("node:util");
const uuid = require("uuid");
const validate = require("har-validator");

Expand Down
2 changes: 1 addition & 1 deletion lib/routes/bins/sample.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
const debug = require("debug")("mockbin");
const util = require("util");
const util = require("node:util");

module.exports = (client) => (req, res, next) => {
client.get(`bin:${req.params.uuid}`, (err, value) => {
Expand Down
2 changes: 1 addition & 1 deletion lib/routes/bins/update.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const debug = require("debug")("mockbin");
const e = require("express");
const validate = require("har-validator");
const path = require("path");
const path = require("node:path");

module.exports = (client) => (req, res, next) => {
const id = req.params.uuid;
Expand Down
2 changes: 1 addition & 1 deletion lib/routes/delay.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module.exports = function delay(req, res, next) {
let delay = req.params.ms ? parseInt(req.params.ms, 10) : 200;
let delay = req.params.ms ? Number.parseInt(req.params.ms, 10) : 200;

if (delay > 60000) {
delay = 60000;
Expand Down
6 changes: 3 additions & 3 deletions lib/routes/redirect.js
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
const util = require("util");
const util = require("node:util");

module.exports = function redirect(req, res, next) {
let count = req.params.count ? parseInt(req.params.count, 10) : 1;
const status = parseInt(req.params.status_code, 10) || 302;
let count = req.params.count ? Number.parseInt(req.params.count, 10) : 1;
const status = Number.parseInt(req.params.status_code, 10) || 302;
const valid = [300, 301, 302, 303, 307, 308];

if (count > 100) {
Expand Down
2 changes: 1 addition & 1 deletion lib/routes/stream.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module.exports = function stream(req, res, next) {
});

// set default chunks to 10
let chunks = req.params.chunks ? parseInt(req.params.chunks, 10) : 10;
let chunks = req.params.chunks ? Number.parseInt(req.params.chunks, 10) : 10;

// max out chunks at 100
if (chunks > 100) {
Expand Down
144 changes: 129 additions & 15 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
"clean": "git clean -fdX"
},
"devDependencies": {
"@biomejs/biome": "1.4.1",
"@biomejs/biome": "1.6.4",
"mocha": "^10.2.0",
"should": "^13.2.3"
},
Expand Down
6 changes: 4 additions & 2 deletions src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ const debug = require("debug")("mockbin");
const express = require("express");
const methodOverride = require("method-override");
const morgan = require("morgan");
const path = require("path");
const path = require("node:path");
const router = require("../lib");

module.exports = (options, done) => {
Expand Down Expand Up @@ -32,7 +32,9 @@ module.exports = (options, done) => {

app.use(
morgan("dev", {
skip: (req, res) => options.quiet === "true" && res.statusCode < 400,
skip: (req, res) =>
req.baseUrl === "/healthcheck" ||
(options.quiet === "true" && res.statusCode < 400),
}),
);

Expand Down
2 changes: 1 addition & 1 deletion src/static/bin/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -178,7 +178,7 @@ $(() => {
});

// fix type issues
response.status = parseInt(response.status, 10);
response.status = Number.parseInt(response.status, 10);

$('input[name="response"]').val(JSON.stringify(response));
$("pre code").text(JSON.stringify(response, null, 2));
Expand Down
2 changes: 1 addition & 1 deletion test/http/index.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
const cookieParser = require("cookie-parser");
const express = require("express");
const mockbin = require("../../lib");
const path = require("path");
const path = require("node:path");

const app = express();
let server = null;
Expand Down
Loading