Upgrade Dockerfile to use node:16-alpine #106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The existing build failed due to node:0.10 being very old. Error: "No compatible version found: cz-conventional-changelog@'>=3.1.0 <4.0.0'" Switching from `node:0.10-onbuild` to `node:16-alpine` required updates to the Dockerfile, adding steps to install dependencies and copy the source code in to the image itself. These are steps that `onbuild` performed for us automatically The Dockerfile was also updated to use `MOCKBIN_REDIS` rather than the `npm config set` method of enabling Redis as the `npm config set` method no longer seems to work
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing build failed due to node:0.10 being very old.
Error: "No compatible version found: cz-conventional-changelog@'>=3.1.0 <4.0.0'"
Switching from
node:0.10-onbuildtonode:16-alpinerequired updates to theDockerfile, adding steps to install dependencies and copy the source code in to
the image itself. These are steps that
onbuildperformed for us automaticallyThe Dockerfile was also updated to use
MOCKBIN_REDISrather than thenpm config setmethod of enabling Redis as thenpm config setmethod nolonger seems to work
Related to #99