Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add timeouts when default client is in use #51

Merged
merged 1 commit into from
May 4, 2021
Merged

feat: add timeouts when default client is in use #51

merged 1 commit into from
May 4, 2021

Commits on May 4, 2021

  1. feat: add timeouts when default client is in use 

    Go's default client has no timeouts and relies on the kernel timeouts,
which goes against the recommended practice of setting timeouts at
application-level whenever possible.

This change ensures that if the default client is used, it is used with
proper timeouts for TCP handshake, TLS handshake and HTTP
request-response lifecycle.

There is no emperical data for the value of 10 seconds.
It is a good starting point and a sane default. Users are encouraged to
create their own http.Client and many users already do so to control
TLSConfig.
    @hbagdi
    hbagdi committed May 4, 2021
    Configuration menu
    Copy the full SHA
    1d822d3 View commit details
    Browse the repository at this point in the history