feat: do not list consumers in a GET Consumer Group call #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gateways before 3.9 return a list of consumers along with consumer_group information, when performing a GET call on a specific consumer_group. This can become slow in case a consumer_group has a lots of consumers. A separate endpoint and relevant constructs already exist to fetch consumers for a particular group. Thus, we are trying to not list consumers while fetching a consumer_group by passing a query parameter in the API call. Gateway 3.9 supports this. This will make decK faster for cases where a consumer- group holds thousands of consumers. For: Kong/deck#1457
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #487 +/- ##
=======================================
Coverage 55.15% 55.15%
=======================================
Files 71 71
Lines 5691 5691
=======================================
Hits 3139 3139
Misses 1935 1935
Partials 617 617
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pmalek
reviewed
Dec 6, 2024
|
Added changelog for both the PRs here: #488 |
pmalek
approved these changes
Dec 6, 2024
pmalek
reviewed
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gateways before 3.9 return a list of consumers
along with consumer_group information, when
performing a GET call on a specific consumer_group. This can become slow in case a consumer_group has
a lots of consumers. A separate endpoint and relevant constructs already exist to fetch consumers for a
particular group. Thus, we are trying to not list
consumers while fetching a consumer_group by passing a query parameter in the API call. Gateway 3.9 supports this.
This will make decK faster for cases where a consumer- group holds thousands of consumers.
For: Kong/deck#1457