add validate method in vault service #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
reviewed
Jan 2, 2024
programmer04
reviewed
Jan 2, 2024
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #392 +/- ##
==========================================
- Coverage 53.16% 53.02% -0.15%
==========================================
Files 69 69
Lines 5212 5226 +14
==========================================
Hits 2771 2771
- Misses 1857 1871 +14
Partials 584 584
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
programmer04
approved these changes
Jan 3, 2024
pmalek
reviewed
Jan 3, 2024
Comment on lines
+161
to
+162
| // returns validate result (passed/failed) and the message from the schema validation service if validation fails. | ||
| // returns a non-nil error if failed to call the schema validation service. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Validate()method to call/schemas/vaults/validateto validate vaults.