Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add FillID() method for vaults #391

Merged
merged 3 commits into from
Jan 3, 2024
Merged

Conversation

randmonkey
Copy link
Contributor

Add FillID method for Vault. Fixes #390.

@randmonkey randmonkey requested a review from a team as a code owner December 28, 2023 04:24
@randmonkey randmonkey requested a review from a team December 28, 2023 04:24
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2023

Codecov Report

Attention: 12 lines in your changes are missing coverage. Please review.

Comparison is base (896a8a3) 53.02% compared to head (af90dd4) 53.04%.

Files Patch % Lines
kong/ids.go 58.82% 5 Missing and 2 partials ⚠️
kong/vault.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #391      +/-   ##
==========================================
+ Coverage   53.02%   53.04%   +0.01%     
==========================================
  Files          69       69              
  Lines        5226     5243      +17     
==========================================
+ Hits         2771     2781      +10     
- Misses       1871     1876       +5     
- Partials      584      586       +2     
Flag Coverage Δ
2.1 33.14% <45.45%> (+0.08%) ⬆️
2.2 44.53% <45.45%> (+0.04%) ⬆️
2.3 45.24% <45.45%> (+0.04%) ⬆️
2.4 45.31% <45.45%> (+0.04%) ⬆️
2.5 45.31% <45.45%> (+0.04%) ⬆️
2.6 45.31% <45.45%> (+0.04%) ⬆️
2.7 46.80% <45.45%> (+0.03%) ⬆️
2.8 46.80% <45.45%> (+0.03%) ⬆️
3.0 50.50% <45.45%> (+0.02%) ⬆️
3.1 51.95% <45.45%> (+0.02%) ⬆️
3.2 52.01% <45.45%> (+0.02%) ⬆️
3.3 52.01% <45.45%> (+0.02%) ⬆️
3.4 52.33% <45.45%> (+0.02%) ⬆️
community 38.33% <45.45%> (+0.06%) ⬆️
enterprise 51.72% <45.45%> (+0.02%) ⬆️
enterprise-nightly 50.69% <45.45%> (+0.02%) ⬆️
integration 53.04% <45.45%> (+0.01%) ⬆️
nightly 37.63% <45.45%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

kong/ids.go Outdated Show resolved Hide resolved
kong/ids.go Outdated Show resolved Hide resolved
kong/ids.go Outdated Show resolved Hide resolved
@randmonkey randmonkey requested a review from pmalek January 3, 2024 03:47
@randmonkey randmonkey merged commit d70e570 into main Jan 3, 2024
67 checks passed
@randmonkey randmonkey deleted the feat/add_vault_fillID branch January 3, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add FillID method for vaults
3 participants