Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support scoping plugins to consumer-groups #352

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Conversation

GGabriele
Copy link
Collaborator

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Jun 23, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.33 ⚠️

Comparison is base (c7d0445) 52.86% compared to head (c28f1a4) 52.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #352      +/-   ##
==========================================
- Coverage   52.86%   52.53%   -0.33%     
==========================================
  Files          69       69              
  Lines        5126     5158      +32     
==========================================
  Hits         2710     2710              
- Misses       1840     1872      +32     
  Partials      576      576              
Flag Coverage Δ
2.1 36.25% <0.00%> (-0.23%) ⬇️
2.2 36.25% <0.00%> (-11.76%) ⬇️
2.3 36.31% <0.00%> (-12.42%) ⬇️
2.4 36.39% <0.00%> (-12.42%) ⬇️
2.5 36.39% <0.00%> (-12.42%) ⬇️
2.6 36.39% <0.00%> (-12.42%) ⬇️
2.7 36.39% <0.00%> (-13.95%) ⬇️
2.8 36.39% <0.00%> (-13.95%) ⬇️
3.0 35.84% <0.00%> (-14.94%) ⬇️
3.1 37.32% <0.00%> (-14.95%) ⬇️
3.2 37.37% <0.00%> (-14.95%) ⬇️
3.3 37.37% <0.00%> (-14.95%) ⬇️
community 37.92% <0.00%> (-0.24%) ⬇️
enterprise 50.65% <0.00%> (-0.87%) ⬇️
enterprise-nightly 50.65% <0.00%> (-0.32%) ⬇️
integration 52.53% <0.00%> (-0.33%) ⬇️
nightly 37.37% <0.00%> (-0.24%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kong/plugin.go 0.00% <ø> (ø)
kong/plugin_service.go 44.10% <0.00%> (-6.11%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GGabriele GGabriele marked this pull request as ready for review July 6, 2023 16:19
@GGabriele GGabriele requested a review from a team as a code owner July 6, 2023 16:19
@GGabriele GGabriele requested a review from a team July 6, 2023 16:19
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this change deserves a Changelog entry, doesn't it?

kong/plugin_service_test.go Outdated Show resolved Hide resolved
kong/plugin_service_test.go Outdated Show resolved Hide resolved
kong/plugin_service.go Outdated Show resolved Hide resolved
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall 👍 but I have some questions about the API decisions

kong/plugin_service.go Show resolved Hide resolved
kong/plugin_service.go Show resolved Hide resolved
kong/plugin_service.go Show resolved Hide resolved
@pmalek pmalek enabled auto-merge (squash) July 7, 2023 12:44
@pmalek pmalek added the enhancement New feature or request label Jul 7, 2023
@pmalek pmalek merged commit 5236d86 into main Jul 7, 2023
45 checks passed
@pmalek pmalek deleted the feat/consumer-groups branch July 7, 2023 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants