Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add GraphQL-RateLimiting-Advanced and DeGraphQL DAOs #288

Merged
merged 7 commits into from
Mar 17, 2023

Conversation

javierguerragiraldez
Copy link
Collaborator

No description provided.

@javierguerragiraldez javierguerragiraldez requested a review from a team as a code owner March 8, 2023 10:14
@javierguerragiraldez javierguerragiraldez force-pushed the feat/add-graphql-rate-limiting-cost-decoration branch 7 times, most recently from f5202b0 to f1b4904 Compare March 8, 2023 14:11
@codecov-commenter
Copy link

codecov-commenter commented Mar 14, 2023

Codecov Report

Patch coverage: 38.62% and project coverage change: -0.61 ⚠️

Comparison is base (fd56d66) 53.46% compared to head (6af901e) 52.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #288      +/-   ##
==========================================
- Coverage   53.46%   52.85%   -0.61%     
==========================================
  Files          64       66       +2     
  Lines        4652     4885     +233     
==========================================
+ Hits         2487     2582      +95     
- Misses       1636     1742     +106     
- Partials      529      561      +32     
Flag Coverage Δ
2.1.4 34.77% <1.28%> (-1.68%) ⬇️
2.2.1.3 45.71% <38.62%> (-0.32%) ⬇️
2.2.2 34.77% <1.28%> (-1.68%) ⬇️
2.3.3 36.41% <1.28%> (-1.76%) ⬇️
2.3.3.4 45.71% <38.62%> (-0.32%) ⬇️
2.4.0 36.49% <1.28%> (-1.77%) ⬇️
2.4.1.3 45.71% <38.62%> (-0.32%) ⬇️
2.5.1 36.49% <1.28%> (-1.77%) ⬇️
2.5.1.2 45.71% <38.62%> (-0.32%) ⬇️
2.6.0 36.49% <1.28%> (-1.77%) ⬇️
2.6.0.2 45.71% <38.62%> (-0.32%) ⬇️
2.7.0 36.49% <1.28%> (-1.77%) ⬇️
2.7.0.0 47.30% <38.62%> (-0.40%) ⬇️
2.8.0 36.49% <1.28%> (-1.77%) ⬇️
2.8.2.2 47.30% <38.62%> (-0.40%) ⬇️
3.0.1 35.92% <1.28%> (-1.74%) ⬇️
3.0.1.0 47.77% <38.62%> (-0.42%) ⬇️
3.1.0 37.48% <1.28%> (-1.82%) ⬇️
3.1.0.0 49.33% <38.62%> (-0.50%) ⬇️
community 38.11% <1.28%> (-1.79%) ⬇️
enterprise 49.90% <38.62%> (-0.53%) ⬇️
enterprise-nightly 49.33% <38.62%> (?)
integration 52.85% <38.62%> (-0.61%) ⬇️
nightly 37.54% <1.28%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...g/graphql_rate_limiting_cost_decoration_service.go 30.68% <30.68%> (ø)
kong/degraphql_route_service.go 41.04% <41.04%> (ø)
kong/client.go 67.43% <72.72%> (+1.43%) ⬆️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@javierguerragiraldez javierguerragiraldez force-pushed the feat/add-graphql-rate-limiting-cost-decoration branch 17 times, most recently from 3de6ce2 to 40532ba Compare March 15, 2023 12:37
@javierguerragiraldez javierguerragiraldez changed the title feat: add GraphQL-RateLimiting-Advanced DAO feat: add GraphQL-RateLimiting-Advanced and DeGraphQL DAOs Mar 15, 2023
kong/graphql_rate_limiting_cost_decoration_service.go Outdated Show resolved Hide resolved
kong/degraphql_route_service_test.go Outdated Show resolved Hide resolved
kong/degraphql_route_service.go Outdated Show resolved Hide resolved
kong/degraphql_route_service.go Show resolved Hide resolved
@javierguerragiraldez javierguerragiraldez force-pushed the feat/add-graphql-rate-limiting-cost-decoration branch 14 times, most recently from e6b09f3 to e8ad6e9 Compare March 16, 2023 01:45
@javierguerragiraldez javierguerragiraldez force-pushed the feat/add-graphql-rate-limiting-cost-decoration branch from e8ad6e9 to 237e1e7 Compare March 16, 2023 01:49
Copy link
Member

@pmalek pmalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good 👍 Some minor nits and I believe we're good to merge.

kong/client.go Show resolved Hide resolved
kong/graphql_rate_limiting_cost_decoration_service.go Outdated Show resolved Hide resolved
kong/degraphql_route_service_test.go Show resolved Hide resolved
kong/degraphql_route_service_test.go Outdated Show resolved Hide resolved
kong/degraphql_route_service_test.go Outdated Show resolved Hide resolved
@javierguerragiraldez javierguerragiraldez force-pushed the feat/add-graphql-rate-limiting-cost-decoration branch from 39fd534 to eeca112 Compare March 16, 2023 11:11
@pmalek
Copy link
Member

pmalek commented Mar 17, 2023

🚢 Thanks!

@pmalek pmalek merged commit ce74ca5 into main Mar 17, 2023
@pmalek pmalek deleted the feat/add-graphql-rate-limiting-cost-decoration branch March 17, 2023 09:34
@pmalek pmalek added the enhancement New feature or request label Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants