fix: correctly fill plugins with arbitrary map fields #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
force-pushed
the
fix/fill-config-for-arbitrary-map
branch
from
3e42cb8 to
b5c669d
Compare
aboudreault
approved these changes
Dec 22, 2022
Kong plugin schemas support different type of fields,
including maps. Moreover, these can either be arbitrary
maps, or maps with their own subschema.
go-kong already supports well the second case, but it
falls short with arbitrary maps. An example of arbitrary
map field is the `custom_fields_by_lua` from the `http-log`
plugin, which is defined as follows:
```
{
"custom_fields_by_lua": {
"keys": {
"len_min": 1,
"type": "string"
},
"type": "map",
"values": {
"len_min": 1,
"type": "string"
}
}
}
```
This commit makes sure that go-kong is able to correctly
handle such schemas as well.
GGabriele
force-pushed
the
fix/fill-config-for-arbitrary-map
branch
from
b5c669d to
6c81ce5
Compare
Codecov ReportBase: 52.32% // Head: 52.43% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #258 +/- ##
==========================================
+ Coverage 52.32% 52.43% +0.11%
==========================================
Files 51 51
Lines 4610 4621 +11
==========================================
+ Hits 2412 2423 +11
Misses 1670 1670
Partials 528 528
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
@Kong/team-k8s this PR is approved (but merge is blocked) and decK is already using this code. Can someone take a look please? |
pmalek
approved these changes
Jan 12, 2023
Done :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kong plugin schemas support different type of fields, including maps. Moreover, these can either be arbitrary maps, or maps with their own subschema.
go-kong already supports well the second case, but it falls short with arbitrary maps. An example of arbitrary map field is the
custom_fields_by_luafrom thehttp-logplugin, which is defined as follows:This commit makes sure that go-kong is able to correctly handle such schemas as well.