feat: support JSON schemas in the FillEntityDefaults function #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
force-pushed
the
feat/json-schemas
branch
from
68057cc
to
23ff0f8
Compare
FillEntityDefaults can be used to inject Kong entity defaults into a Kong entity struct. This function achieves this by getting entity schemas from the Admin API, flattening the returned schemas and merging these with the input schemas. Kong CP only works with Lua schemas, while Konnect also supports JSON schemas. This commit adds support to filling entity defaults from JSON schemas.
GGabriele
force-pushed
the
feat/json-schemas
branch
from
23ff0f8
to
31bb22f
Compare
Codecov ReportBase: 53.01% // Head: 53.39% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #231 +/- ##
==========================================
+ Coverage 53.01% 53.39% +0.38%
==========================================
Files 46 46
Lines 4142 4178 +36
==========================================
+ Hits 2196 2231 +35
- Misses 1469 1470 +1
Partials 477 477
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
pmalek
requested changes
Oct 24, 2022
pmalek
reviewed
Nov 8, 2022
pmalek
approved these changes
Nov 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FillEntityDefaults can be used to inject Kong entity defaults into a Kong entity struct. This function achieves this by getting entity schemas from the Admin API, flattening the returned schemas and merging these with the input schemas.
Kong CP only works with Lua schemas, while Konnect also supports JSON schemas.
This commit adds support to filling entity defaults from JSON schemas.