Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client) add configuration_hash to Status #150

Merged
merged 1 commit into from
Mar 21, 2022
Merged

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Mar 21, 2022

Adds support for the configuration hash added to 2.8's status endpoint.

@rainest rainest requested a review from a team as a code owner March 21, 2022 19:53
@codecov-commenter
Copy link

codecov-commenter commented Mar 21, 2022

Codecov Report

Merging #150 (3d22f46) into main (99289e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #150   +/-   ##
=======================================
  Coverage   45.38%   45.38%           
=======================================
  Files          44       44           
  Lines        3962     3962           
=======================================
  Hits         1798     1798           
  Misses       1827     1827           
  Partials      337      337           
Flag Coverage Δ
2.0.5 39.67% <ø> (ø)
2.1.4 39.50% <ø> (ø)
2.2.2 39.50% <ø> (ø)
2.3.3 39.50% <ø> (ø)
2.4.0 39.50% <ø> (ø)
2.5.1 39.50% <ø> (ø)
2.6.0 39.50% <ø> (ø)
2.7.0 39.50% <ø> (ø)
community 39.67% <ø> (ø)
enterprise 44.95% <ø> (ø)
enterprise-1.5.0.11 44.95% <ø> (ø)
enterprise-2.1.4.6 43.86% <ø> (ø)
enterprise-2.2.1.3 43.86% <ø> (ø)
enterprise-2.3.3.4 43.86% <ø> (ø)
enterprise-2.4.1.3 43.86% <ø> (ø)
enterprise-2.5.1.2 43.86% <ø> (ø)
enterprise-2.6.0.2 43.86% <ø> (ø)
enterprise-2.7.0.0 43.86% <ø> (ø)
integration 45.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
kong/client.go 60.19% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99289e1...3d22f46. Read the comment docs.

Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would just say make sure we do a manual check against an image that has the hash before merging and then 👍

@rainest
Copy link
Contributor Author

rainest commented Mar 21, 2022

Waiting on https://github.com/Kong/kubernetes-ingress-controller/actions/runs/2018716499, which will test this by virtue of requiring this go-kong feature to work.

@rainest
Copy link
Contributor Author

rainest commented Mar 21, 2022

Right then, overall test failed, but because some unrelated test had a bug uncovered by a fix elsewhere. The test that matters for this succeeded.

@rainest rainest merged commit bd63e50 into main Mar 21, 2022
@rainest rainest deleted the feat/status-hash branch March 21, 2022 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants