Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: marshall and unmarshall actions on endpoint permissions #148

Merged
merged 10 commits into from
Mar 25, 2022
Prev Previous commit
Next Next commit
fix(tests) provide entity type for permission
Provide entity type for permission that requires it.

Expand default entity permissions to all actions, to not actually limit
the admin's ability to interact with objects. We care that we can
interact with permissions; enforcing them is the Gateway's domain.
rainest committed Mar 22, 2022
commit 40b81cb451ab94bf56574262428f7797e4b4ccd0
5 changes: 4 additions & 1 deletion kong/entity_permission_service_test.go
Original file line number Diff line number Diff line change
@@ -110,13 +110,16 @@ func TestRBACEntityPermissionserviceList(T *testing.T) {
Actions: []*string{
String("create"),
String("read"),
String("update"),
String("delete"),
},
}
ep2 := &RBACEntityPermission{
Role: &RBACRole{
ID: createdRole.ID,
},
EntityID: createdWorkspace.ID,
EntityID: createdWorkspace.ID,
EntityType: String("workspaces"),
Actions: []*string{
String("update"),
String("delete"),