chore: downgrade and pin color #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Why does it merge the PR if CI fails? In general if CI fails the PR's should not be auto-merged. Instead of having exceptions in the workflow files, we can, per version, respond on the dependabot PR. |
|
something like this one by Ahmed; https://github.com/marketplace/actions/dependabot-auto-merge |
|
The dependabot thing came from what's ostensibly our new repo template, though IDK how well that's maintained. I don't think it's intended to have much intelligence about test status itself. The merge happened because all required statuses were green, as we in fact do not have and never had required statuses in deck or here 🤷 #25 borrows the thing KIC uses to pool the required checks together into a single status. |
GGabriele
approved these changes
Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Downgrade the github.com/fatih/color library to 1.15. See prior reasoning in Kong/deck#1109. Unfortunately dependabot upgraded it. This also adds config to not do that again.
Issues resolved
Avoids an issue with logs formatting improperly pending future removal of the library: #22