fix: added fix to allow one consumer to be in >1 consumer-groups. #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be in >1 consumer-groups. gdr version 1.39.2 introduced a bug where a consumer was limited to only one consumer-group. Adding the consumer in >1 group was resulting in an error on deck. This PR adds the fix for the same and an integration test. See: Kong/deck#1384
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #140 +/- ##
==========================================
- Coverage 29.96% 29.95% -0.02%
==========================================
Files 106 106
Lines 12583 12589 +6
==========================================
Hits 3771 3771
- Misses 8352 8358 +6
Partials 460 460 ☔ View full report in Codecov by Sentry. |
samugi
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gdr version 1.39.2 introduced a bug where a consumer was limited to only one consumer-group.
Adding the consumer in >1 group was resulting in an error on deck. This PR adds the fix for the same and an integration test.
See: Kong/deck#1384