Fix: Expression route handling fix for Konnect and < v3.7.0 #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
==========================================
+ Coverage 41.23% 41.35% +0.12%
==========================================
Files 75 75
Lines 10892 10895 +3
==========================================
+ Hits 4491 4506 +15
+ Misses 5937 5925 -12
Partials 464 464 ☔ View full report in Codecov by Sentry. |
v3.7.0 added changes to allow traditional route fields with expression routes, thus making expression router a superset of traditional router. Ref: Kong/kong#12667 Thus, keys like regex_priority are not supported in versions lesser than 3.7.0. Added a gating logic in state builder for the necessary changes and fixed tests. Fix #1250
Prashansa-K
force-pushed
the
fix/version-logic-for-expression-routes
branch
from
0972e1b to
3f999c9
Compare
GGabriele
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
v3.7.0 added changes to allow traditional route fields with expression routes, thus making expression router a superset of traditional router.
Ref: Kong/kong#12667
Thus, keys like regex_priority are not supported in versions lesser than 3.7.0.
Added a gating logic in state builder for the necessary changes and fixed tests.
Fix #1250
Full changelog
Issues resolved
Fix #1250
Documentation
Testing