Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make the DECK_ envvar prefix configurable #106

Merged
merged 1 commit into from
Jun 21, 2024
Merged

Conversation

Tieske
Copy link
Member

@Tieske Tieske commented Jun 21, 2024

Summary

default remains DECK_ so no functional changes to existing code. also adds tests for rendering files.

Testing

  • Unit tests
  • E2E tests
  • Manual testing on Universal
  • Manual testing on Kubernetes

@Tieske Tieske requested a review from a team June 21, 2024 13:23
default remains DECK_ so no functional changes to existing code.
also adds tests for rendering files.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 41.17%. Comparing base (6d3c2b3) to head (8386919).

Files Patch % Lines
pkg/file/template.go 75.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #106   +/-   ##
=======================================
  Coverage   41.16%   41.17%           
=======================================
  Files          75       75           
  Lines       10807    10807           
=======================================
+ Hits         4449     4450    +1     
+ Misses       5896     5895    -1     
  Partials      462      462           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Tieske Tieske merged commit 1047bbb into main Jun 21, 2024
42 checks passed
@Tieske Tieske deleted the feat/varprefix branch June 21, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants