fix: correct diffs when comparing objects with empty tags #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, when some declarative configuration having empty tags
on any of its entities is deployed, subsequent `diff` / `sync`
will show misleading results:
```
$ cat kong.yaml
_format_version: "3.0"
services:
- name: foo
protocol: http
host: foo
port: 8000
tags: []
$ deck sync
creating service foo
Summary:
Created: 1
Updated: 0
Deleted: 0
$ deck sync
updating service foo {
"connect_timeout": 60000,
"enabled": true,
"host": "foo",
"id": "afadd2ed-2bcd-49fc-9000-adb58cd11b50",
"name": "foo",
"port": 8000,
"protocol": "http",
"read_timeout": 60000,
"retries": 5,
"write_timeout": 60000
}
Summary:
Created: 0
Updated: 1
Deleted: 0
```
The second `deck sync` run is showing an update without an actual diff.
This is due to the way empty tags are treated internally in decK.
This commit fixes this defect.
Tieske
previously approved these changes
Jul 26, 2023
done |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #985 +/- ##
==========================================
+ Coverage 33.71% 34.06% +0.34%
==========================================
Files 100 100
Lines 12006 12106 +100
==========================================
+ Hits 4048 4124 +76
- Misses 7564 7588 +24
Partials 394 394
☔ View full report in Codecov by Sentry. |
Tieske
approved these changes
Jul 27, 2023
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
Right now, when some declarative configuration having empty tags
on any of its entities is deployed, subsequent `diff` / `sync`
will show misleading results:
```
$ cat kong.yaml
_format_version: "3.0"
services:
- name: foo
protocol: http
host: foo
port: 8000
tags: []
$ deck sync
creating service foo
Summary:
Created: 1
Updated: 0
Deleted: 0
$ deck sync
updating service foo {
"connect_timeout": 60000,
"enabled": true,
"host": "foo",
"id": "afadd2ed-2bcd-49fc-9000-adb58cd11b50",
"name": "foo",
"port": 8000,
"protocol": "http",
"read_timeout": 60000,
"retries": 5,
"write_timeout": 60000
}
Summary:
Created: 0
Updated: 1
Deleted: 0
```
The second `deck sync` run is showing an update without an actual diff.
This is due to the way empty tags are treated internally in decK.
This commit fixes this defect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, when some declarative configuration having empty tags on any of its entities is deployed, subsequent
diff/syncwill show misleading results:The second
deck syncrun is showing an update without an actual diff. This is due to the way empty tags are treated internally in decK.This commit fixes this defect.