feat: parsing numbers in templates #868
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zekth
commented
Mar 17, 2023
file/readfile_test.go
Outdated
| Plugin: kong.Plugin{ | ||
| Name: kong.String("foofloat"), | ||
| Config: kong.Configuration{ | ||
| "foo": *kong.Float64(1337), |
There was a problem hiding this comment.
weirdly the assertions seems to fail on this one if i don't use the value. However it works fine for the parseInt.
There was a problem hiding this comment.
That's because plugins' config stores actual values, not pointers (like for other non-plugin entities). You can rewrite this as float64(1337).
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #868 +/- ##
==========================================
+ Coverage 35.56% 35.59% +0.03%
==========================================
Files 92 92
Lines 11267 11273 +6
==========================================
+ Hits 4007 4013 +6
Misses 6867 6867
Partials 393 393
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
zekth
force-pushed
the
feat/parsing-templates
branch
from
6bb82d5
to
9c47085
Compare
GGabriele
approved these changes
Mar 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #867