fix: workspaces validation with multiple files #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running `deck sync` with multiple state files,
either by passing multiple `-s` flags
(e.g. `-s foo.yaml -s bar.yaml`) or by passing a folder
(e.g. `-s ./statefiles`), decK merges the whole configuration
from all files and it fails the content validation if different
`_workspace` entries are found. While this is good and
expected by design, decK also fails in the following case:
```
$ cat foo.yaml
services:
- name: svc1
host: 1.example.com
tags:
- team-svc1
routes:
- name: r1
paths:
- /r1
$ cat meta.yaml
_format_version: "1.1"
_workspace: bar
```
The error from decK would be the following:
```
$ deck sync -s meta.yaml -s foo.yaml
Error: it seems like you are trying to sync multiple workspaces at the same time ([ bar]).
decK doesn't support syncing multiple workspaces at the same time, please sync one workspace at a time
```
The reason why decK is failing is because it's adding an empty
workspace to the array used for validation because
the `foo.yaml` state file is missing the `_workspace` entry.
This commit makes sure that the "emtpy workspace" is not
considered at workspace validation time.
GGabriele
temporarily deployed
to
Configure ci
GitHub Actions
Inactive
Codecov ReportBase: 35.44% // Head: 35.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #839 +/- ##
==========================================
+ Coverage 35.44% 35.45% +0.01%
==========================================
Files 92 92
Lines 11245 11247 +2
==========================================
+ Hits 3986 3988 +2
Misses 6862 6862
Partials 397 397
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
deck syncwith multiple state files, either by passing multiple-sflags(e.g.
-s foo.yaml -s bar.yaml) or by passing a folder (e.g.-s ./statefiles), decK merges the whole configuration from all files and it fails the content validation if different_workspaceentries are found. While this is good and expected by design, decK also fails in the following case:The error from decK would be the following:
The reason why decK is failing is because it's adding an empty workspace to the array used for validation because the
foo.yamlstate file is missing the_workspaceentry.This commit makes sure that the "emtpy workspace" is not considered at workspace validation time.