update Dockerfile to run as non-root #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Guus van Weelden <guus.vanweelden@moia.io>
hutchic
reviewed
Oct 6, 2019
.dockerignore
Outdated
| @@ -1,2 +1,3 @@ | |||
| .git | |||
| .travis.yml | |||
There was a problem hiding this comment.
removed it. it was part of the .dockerignore, but fine for me ;)
guusvw
commented
Oct 6, 2019
hbagdi
requested changes
Oct 6, 2019
guusvw
commented
Oct 6, 2019
guusvw
commented
Oct 6, 2019
guusvw
commented
Oct 6, 2019
guusvw
commented
Oct 6, 2019
guusvw
commented
Oct 6, 2019
guusvw
commented
Oct 6, 2019
|
There is no reason to add all that group and env into the file. You are only copying a binary into the folder. Have you looked or ran my dockerfile? |
guusvw
commented
Oct 7, 2019
Comment on lines
+14
to
+17
| ARG USER=deck | ||
| ARG GROUP=deck | ||
| ARG UID=9999 | ||
| ARG GID=9999 |
There was a problem hiding this comment.
This allows you to set those variables from outside during the build time of the container @digikin
There was a problem hiding this comment.
I don't think we really had to template these in the first place. This is a self-contained and small Dockerfile.
No strong feelings here so not changes necessary.
hbagdi
reviewed
Oct 9, 2019
| RUN apk --no-cache add ca-certificates | ||
| WORKDIR /root/ | ||
| RUN apk update \ | ||
| && apk upgrade \ |
There was a problem hiding this comment.
Why is an upgrade necessary here?
|
@guusvw Friendly ping. |
|
#84 implements this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
solves #82
Signed-off-by: Guus van Weelden guus.vanweelden@moia.io