Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enhance error messages during dump for plugins #791

Merged
merged 1 commit into from
Nov 11, 2022

Conversation

mikefero
Copy link
Contributor

This update adds additional information if a failure occurs when gathering referenced (or parent) resources; consumer, service, and route. The error message will contain the ID of the referenced resource that failed to be retrieved and include the plugin ID and name for easily identifying where the missing resource is referenced.

This update adds additional information if a failure occurs when
gathering referenced (or parent) resources; consumer, service, and
route. The error message will contain the ID of the referenced resource
that failed to be retrieved and include the plugin ID and name for
easily identifying where the missing resource is referenced.
@mikefero mikefero requested a review from a team November 10, 2022 23:37
@mikefero mikefero temporarily deployed to Configure ci November 10, 2022 23:37 Inactive
@CLAassistant
Copy link

CLAassistant commented Nov 10, 2022

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@mikefero
Copy link
Contributor Author

@GGabriele I think a lot of the other errors in this file could be wrapped in a similar fashion to give more feedback on the error that occurred. There are some instances where it wouldn't make sense to fully wrap the error as this would change how a lot of the code base is currently instrumented.

@mikefero mikefero merged commit 0ef6aab into main Nov 11, 2022
@mikefero mikefero deleted the feat/enhance-error-messages-for-dump branch November 11, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants