Feat/vaults #761
Feat/vaults #761
Conversation
|
Tested and confirmed this works well with DB-less declarative config too. |
Codecov ReportBase: 39.82% // Head: 39.00% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #761 +/- ##
==========================================
- Coverage 39.82% 39.00% -0.82%
==========================================
Files 87 88 +1
Lines 9875 10103 +228
==========================================
+ Hits 3933 3941 +8
- Misses 5563 5777 +214
- Partials 379 385 +6
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
LGTM @GGabriele, only a minor comment in tests. I tested this deck feature with kong gateway 3.0 and it works well (sync, dump, re-sync diff, etc.). Also tested a vault reference in a plugin (rate-limiting) and things look good there too. 👍
| certificates: | ||
| - id: 13c562a1-191c-4464-9b18-e5222b46035b | ||
| cert: "{vault://env/my-secret-cert}" | ||
| key: "{vault://env/my-secret-key}" |
There was a problem hiding this comment.
if we want to test the vault entity, we should set these vault references to {vault://my-env-vault/key}
There was a problem hiding this comment.
Good catch, thanks!
Requires Kong/go-kong#224