-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to consumer_groups #760
Conversation
dd15454
to
2cf2b5b
Compare
Codecov ReportBase: 38.88% // Head: 35.52% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #760 +/- ##
==========================================
- Coverage 38.88% 35.52% -3.36%
==========================================
Files 88 92 +4
Lines 10205 11219 +1014
==========================================
+ Hits 3968 3986 +18
- Misses 5851 6836 +985
- Partials 386 397 +11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
2cf2b5b
to
bb58984
Compare
bb58984
to
9bc8444
Compare
9bc8444
to
fed8b62
Compare
fed8b62
to
12afae4
Compare
12afae4
to
75256c3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @GGabriele !! I looked at all files and I don't see any blocker. There is a lot in this PR and it's not obvious to catch possible bugs while reviewing. However, I tested this deck PR with Konnect with multiple different cases (sync/dump/diff etc.) and things seem to work well. I am continuing some more testing but I'd say +1.
f068938
to
0f9a7a9
Compare
Hello @GGabriele , about consumer-groups support, with 1.17.0 deck release I cannot dump or sync from free kong anymore, while with 1.16.0 was possible. The error given was: Error: reading configuration from Kong: consumer_groups: HTTP status 403 (message: "Enterprise license missing or expired") |
Hi @sscarpanti70 , what Kong version are you using? |
3.1.1.1, without any license so far
Il giorno gio 12 gen 2023 alle ore 16:02 Gabriele ***@***.***>
ha scritto:
… Hi @sscarpanti70 <https://github.com/sscarpanti70> , what Kong version
are you using?
—
Reply to this email directly, view it on GitHub
<#760 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5G6A4MSZAHH25DDDGH6KIDWSAMI3ANCNFSM6AAAAAAQ4KCVZM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
I can't understand if since 1.17.0 deck a license is needed to sync with
kong or I have to add a specific user to fix connection
Il giorno gio 12 gen 2023 alle ore 16:08 Stefano Scarpanti <
***@***.***> ha scritto:
… 3.1.1.1, without any license so far
Il giorno gio 12 gen 2023 alle ore 16:02 Gabriele <
***@***.***> ha scritto:
> Hi @sscarpanti70 <https://github.com/sscarpanti70> , what Kong version
> are you using?
>
> —
> Reply to this email directly, view it on GitHub
> <#760 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/A5G6A4MSZAHH25DDDGH6KIDWSAMI3ANCNFSM6AAAAAAQ4KCVZM>
> .
> You are receiving this because you were mentioned.Message ID:
> ***@***.***>
>
|
I see the problem, you're using an enterprise version of Kong without a license and decK is not checking for this case. I will push a fix and do path release. Thanks for raising this! |
Hello Gabriele,
I just let you know about a workaround we found with 1.17.1, simply
specifying workspace
deck -w default sync -s setup_3x.yaml --select-tag inso-single
It works perfectly. Also dump.
Il giorno gio 12 gen 2023 alle ore 21:29 Gabriele ***@***.***>
ha scritto:
… I see the problem, you're using an enterprise version of Kong without a
license and decK is not checking for this case.
I will push a fix and do path release. Thanks for raising this!
—
Reply to this email directly, view it on GitHub
<#760 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5G6A4K4VAYWS5M7SZWOOGTWSBSUNANCNFSM6AAAAAAQ4KCVZM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks for letting me know! In the mean time, I just opened this: #821 |
That's great!
Il giorno ven 13 gen 2023 alle ore 14:58 Gabriele ***@***.***>
ha scritto:
… Thanks for letting me know!
In the mean time, I just opened this: #821
<#821>
—
Reply to this email directly, view it on GitHub
<#760 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A5G6A4PBA75OER4CO4S5N6TWSFNRXANCNFSM6AAAAAAQ4KCVZM>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
https://docs.konghq.com/gateway/3.0.x/admin-api/consumer-groups/reference/
Needs some go-kong changes first: Kong/go-kong#221