Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support to consumer_groups #760

Merged
merged 3 commits into from
Dec 20, 2022
Merged

feat: add support to consumer_groups #760

merged 3 commits into from
Dec 20, 2022

Conversation

GGabriele
Copy link
Collaborator

@GGabriele GGabriele temporarily deployed to Configure ci October 4, 2022 08:11 Inactive
@GGabriele GGabriele temporarily deployed to Configure ci November 21, 2022 16:35 Inactive
@GGabriele GGabriele temporarily deployed to Configure ci November 21, 2022 16:35 Inactive
@codecov-commenter
Copy link

codecov-commenter commented Nov 21, 2022

Codecov Report

Base: 38.88% // Head: 35.52% // Decreases project coverage by -3.35% ⚠️

Coverage data is based on head (0f9a7a9) compared to base (be0eaa0).
Patch coverage: 2.43% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #760      +/-   ##
==========================================
- Coverage   38.88%   35.52%   -3.36%     
==========================================
  Files          88       92       +4     
  Lines       10205    11219    +1014     
==========================================
+ Hits         3968     3986      +18     
- Misses       5851     6836     +985     
- Partials      386      397      +11     
Impacted Files Coverage Δ
cmd/common.go 5.20% <0.00%> (-0.04%) ⬇️
cmd/common_konnect.go 7.22% <0.00%> (-0.17%) ⬇️
cmd/reset.go 0.00% <0.00%> (ø)
diff/diff.go 0.00% <0.00%> (ø)
diff/order.go 79.16% <ø> (ø)
dump/dump.go 1.41% <0.00%> (-0.16%) ⬇️
file/types.go 59.71% <0.00%> (-1.42%) ⬇️
konnect/consumer_group.go 0.00% <0.00%> (ø)
state/builder.go 0.00% <0.00%> (ø)
state/consumer_group.go 0.00% <0.00%> (ø)
... and 11 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GGabriele GGabriele temporarily deployed to Configure ci November 21, 2022 16:56 Inactive
@GGabriele GGabriele temporarily deployed to Configure ci November 21, 2022 16:56 Inactive
@GGabriele GGabriele temporarily deployed to Configure ci December 12, 2022 14:24 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci December 12, 2022 14:24 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci December 12, 2022 14:32 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci December 12, 2022 14:32 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci December 12, 2022 14:39 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci December 12, 2022 14:39 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci December 12, 2022 16:52 — with GitHub Actions Inactive
@GGabriele GGabriele marked this pull request as ready for review December 13, 2022 16:12
@GGabriele GGabriele requested a review from a team December 13, 2022 16:12
aboudreault
aboudreault previously approved these changes Dec 15, 2022
Copy link
Contributor

@aboudreault aboudreault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @GGabriele !! I looked at all files and I don't see any blocker. There is a lot in this PR and it's not obvious to catch possible bugs while reviewing. However, I tested this deck PR with Konnect with multiple different cases (sync/dump/diff etc.) and things seem to work well. I am continuing some more testing but I'd say +1.

dump/dump.go Show resolved Hide resolved
dump/dump.go Outdated Show resolved Hide resolved
dump/dump.go Outdated Show resolved Hide resolved
@GGabriele GGabriele temporarily deployed to Configure ci December 15, 2022 18:12 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci December 15, 2022 18:12 — with GitHub Actions Inactive
aboudreault
aboudreault previously approved these changes Dec 15, 2022
@GGabriele GGabriele temporarily deployed to Configure ci December 19, 2022 17:14 — with GitHub Actions Inactive
@GGabriele GGabriele temporarily deployed to Configure ci December 19, 2022 17:14 — with GitHub Actions Inactive
@GGabriele GGabriele merged commit 8cd2c98 into main Dec 20, 2022
@GGabriele GGabriele deleted the feat/consumer-groups branch December 20, 2022 12:17
@sscarpanti70
Copy link

Hello @GGabriele , about consumer-groups support, with 1.17.0 deck release I cannot dump or sync from free kong anymore, while with 1.16.0 was possible. The error given was: Error: reading configuration from Kong: consumer_groups: HTTP status 403 (message: "Enterprise license missing or expired")

@GGabriele
Copy link
Collaborator Author

Hi @sscarpanti70 , what Kong version are you using?

@sscarpanti70
Copy link

sscarpanti70 commented Jan 12, 2023 via email

@sscarpanti70
Copy link

sscarpanti70 commented Jan 12, 2023 via email

@GGabriele
Copy link
Collaborator Author

I see the problem, you're using an enterprise version of Kong without a license and decK is not checking for this case.

I will push a fix and do path release. Thanks for raising this!

@sscarpanti70
Copy link

sscarpanti70 commented Jan 13, 2023 via email

@GGabriele
Copy link
Collaborator Author

Thanks for letting me know!

In the mean time, I just opened this: #821

@sscarpanti70
Copy link

sscarpanti70 commented Jan 13, 2023 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants