Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: correct order of precedence to gate Konnect mode #738

Merged
merged 1 commit into from
Sep 26, 2022

Commits on Aug 19, 2022

  1. fix: correct order of precedence to gate Konnect mode

    Right now decK runs against Konnect if some Konnect
    credentials are around, either via command flags or via
    environment variables. In the case of having a `kong-addr`
    different from the default value and some lingering Konnect
    credentials environment variables set, decK would still
    decide to run against Konnect instead of Kong.
    
    This PR is reworking the order of precedence gating Konnect:
    1. if the config file contains the `_konnect` entry, run
       against Konnect
    2. if the `kong-addr` is set to a non-default value, run
       against Kong
    3. if some Konnect credentials are set, run against Konnect
    4. otherwise run against Kong
    GGabriele committed Aug 19, 2022
    Configuration menu
    Copy the full SHA
    5065a7d View commit details
    Browse the repository at this point in the history