feat: support multi-geo for Konnect #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please rebase. |
done |
hbagdi
reviewed
Aug 18, 2022
konnect/login_service.go
Outdated
| } | ||
|
|
||
| parts := strings.Split(baseURL, "api.konghq") | ||
| endpoint := baseEndpointUS + parts[len(parts)-1] + authEndpointV2 |
There was a problem hiding this comment.
I think it would be best to pull this out and unit test it thoroughly to just be sure. Breeding ground for a bug.
Codecov Report
@@ Coverage Diff @@
## main #732 +/- ##
==========================================
- Coverage 43.05% 39.98% -3.07%
==========================================
Files 74 87 +13
Lines 9016 9715 +699
==========================================
+ Hits 3882 3885 +3
- Misses 4763 5459 +696
Partials 371 371
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
hbagdi
previously approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.