Add support for plugin ordering #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 6, 2022
|
Looks great! Would you mind adding an integration tests for kong version >=3.0.0 ? |
Codecov Report
@@ Coverage Diff @@
## main #710 +/- ##
==========================================
- Coverage 43.27% 43.24% -0.03%
==========================================
Files 74 74
Lines 8970 8976 +6
==========================================
Hits 3882 3882
- Misses 4718 4723 +5
- Partials 370 371 +1
Continue to review full report at Codecov.
|
rainest
force-pushed
the
feat/plugin-order
branch
4 times, most recently
from
1e9015b to
c3b12d8
Compare
|
Tested along with adding the Enterprise nightly. Still draft pending a go-kong release. This breaks one of the existing tests--it looks like the 3.0 defaults add websocket protocols--so that's now limited to under 3.0. |
rainest
force-pushed
the
feat/plugin-order
branch
from
31bc3e2 to
b3babf5
Compare
GGabriele
approved these changes
Jul 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for the new plugin ordering field. Draft pending Kong/go-kong#187 and a go-kong release.