fix: update consumers when custom_id is also set #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GGabriele
force-pushed
the
fix/update-consumer-with-custom-id
branch
from
cd0b014 to
c27845a
Compare
Codecov Report
@@ Coverage Diff @@
## main #707 +/- ##
==========================================
- Coverage 43.50% 43.47% -0.03%
==========================================
Files 74 74
Lines 8923 8933 +10
==========================================
+ Hits 3882 3884 +2
- Misses 4671 4677 +6
- Partials 370 372 +2
Continue to review full report at Codecov.
|
GGabriele
force-pushed
the
fix/update-consumer-with-custom-id
branch
from
c27845a to
57a5e97
Compare
GGabriele
force-pushed
the
fix/update-consumer-with-custom-id
branch
from
57a5e97 to
5a288f7
Compare
Right now decK only uses ID and Username for Consumers lookup, which is problematic because CustomID is also unique and modifying a Username causes a Consumer re-creation, which triggers a collision for the CustomID field. This PR makes sure that CustomID is included in the lookup loop, so that such Consumers changes can be made in-place.
GGabriele
force-pushed
the
fix/update-consumer-with-custom-id
branch
from
5a288f7 to
8cdd4a8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now decK only uses ID and Username for Consumers lookup,
which is problematic because CustomID is also unique and
modifying a Username causes a Consumer re-creation, which
triggers a collision for the CustomID field.
This PR makes sure that CustomID is included in the lookup
loop, so that such Consumers changes can be made in-place.
Solves #698