fix: improve errors when running against Konnect with workspace config #696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmalek
previously approved these changes
Jun 7, 2022
hbagdi
requested changes
Jun 14, 2022
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #696 +/- ##
==========================================
- Coverage 39.82% 39.79% -0.04%
==========================================
Files 87 87
Lines 9875 9884 +9
==========================================
Hits 3933 3933
- Misses 5563 5572 +9
Partials 379 379 ☔ View full report in Codecov by Sentry. |
jrsmroz
reviewed
Jun 15, 2022
cmd/common.go
Outdated
| @@ -101,6 +101,14 @@ func syncMain(ctx context.Context, filenames []string, dry bool, parallelism, | |||
| var kongClient *kong.Client | |||
| mode := getMode(targetContent) | |||
| if mode == modeKonnect { | |||
| if targetContent.Workspace != "" { | |||
| return fmt.Errorf("_workspace set in config file.\n" + | |||
There was a problem hiding this comment.
Does it need to be multi line error message (\n)?
GGabriele
force-pushed
the
fix/workspace-konnect
branch
from
3e3e4f7 to
9ef8a61
Compare
|
Please rebase. |
GGabriele
force-pushed
the
fix/workspace-konnect
branch
from
9ef8a61 to
5810ada
Compare
done |
pmalek
requested changes
Aug 17, 2022
GGabriele
force-pushed
the
fix/workspace-konnect
branch
from
5810ada to
5f184eb
Compare
GGabriele
force-pushed
the
fix/workspace-konnect
branch
from
5f184eb to
de491a8
Compare
hbagdi
reviewed
Aug 18, 2022
cmd/common.go
Outdated
| if targetContent.Workspace != "" { | ||
| return fmt.Errorf("_workspace set in config file.\n" + | ||
| "Workspaces are not supported in Konnect. " + | ||
| "Please remove '_workspace: foo' from your configuration and try again") |
There was a problem hiding this comment.
'foo' seems to be a copy-paste error. Could you please update the error message to include the workspace that the user has provided?
There was a problem hiding this comment.
done
$ ./deck sync --konnect-token $TOKEN_DEV
Error: _workspace set in config file.
Workspaces are not supported in Konnect. Please remove '_workspace: test' from your configuration and try again
de491a8 to
02f125d
Compare
GGabriele
force-pushed
the
fix/workspace-konnect
branch
from
02f125d to
05f0bcd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.