Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: strip references name for plugins and routes #693

Merged
merged 1 commit into from
Jun 3, 2022

Conversation

GGabriele
Copy link
Collaborator

Kong and Konnect APIs only require IDs for referenced entities.
In some cases, injecting the entities name in the requests is
problematic. This makes sure these names are stripped before making
API requests, while preserving the capability of logging user-friendly
messages as added in #662

Kong and Konnect APIs only require IDs for referenced entities.
In some cases, injecting the entities name in the requests is
problematic. This makes sure these names are stripped before making
API requests, while preserving the capability of logging user-friendly
messages as added in #662
@GGabriele GGabriele requested a review from a team as a code owner June 3, 2022 10:46
@rainest rainest enabled auto-merge (rebase) June 3, 2022 15:58
Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like it'd make sense to inline these since we only use them in one place and because they operate entirely through side effects, but IDK, may be a bit bikesheddy and no change to the end results.

@rainest rainest merged commit 866ed89 into main Jun 3, 2022
@rainest rainest deleted the fix/service-reference-konnect branch June 3, 2022 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants