Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: inject deck version into User-Agent header for konnect #654

Merged
merged 1 commit into from
May 2, 2022

Conversation

GGabriele
Copy link
Collaborator

No description provided.

@GGabriele GGabriele requested a review from a team as a code owner April 22, 2022 19:59
@codecov-commenter
Copy link

Codecov Report

Merging #654 (461f555) into main (e6da448) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #654      +/-   ##
==========================================
- Coverage   44.37%   44.36%   -0.02%     
==========================================
  Files          74       74              
  Lines        8778     8780       +2     
==========================================
  Hits         3895     3895              
- Misses       4522     4524       +2     
  Partials      361      361              
Impacted Files Coverage Δ
cmd/common_konnect.go 7.75% <0.00%> (-0.07%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6da448...461f555. Read the comment docs.

@hbagdi
Copy link
Member

hbagdi commented Apr 22, 2022

Will this inject the user-agent header into the auth requests?

@GGabriele
Copy link
Collaborator Author

Will this inject the user-agent header into the auth requests?

Yes, the headers are part of the konnectConfig which are injected here

@hbagdi hbagdi merged commit f73967a into main May 2, 2022
@hbagdi hbagdi deleted the konnect_headers branch May 2, 2022 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants