feat: deploy konnect via main deck command #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #645 +/- ##
==========================================
- Coverage 45.61% 44.57% -1.05%
==========================================
Files 74 74
Lines 8536 8738 +202
==========================================
+ Hits 3894 3895 +1
- Misses 4283 4482 +199
- Partials 359 361 +2 ☔ View full report in Codecov by Sentry. |
hbagdi
reviewed
Apr 19, 2022
utils/analytics.go
Outdated
| if mode == konnectMode { | ||
| result["mode"] = mode | ||
| } | ||
| if kongVersion != "" || mode != konnectMode { |
There was a problem hiding this comment.
Suggested change
| if kongVersion != "" || mode != konnectMode { | |
| if kongVersion != "" && mode != konnectMode { |
| -----END CERTIFICATE----- | ||
| cert_digest: b865971cecadd7bac9487901c9269c1fa903b3a3b521a927c5e2513f692ac61e | ||
| cert_digest: 34e0f1f3d83faefcc8514b6295bc822eab1110dc120140ddf342c017baee8c0f |
There was a problem hiding this comment.
Unrelated change, please send another PR.
konnect/login_service.go
Outdated
| } | ||
| req, err := s.client.NewRequest(http.MethodPost, authEndpointV2, nil, body) | ||
| if err != nil { | ||
| return AuthResponse{}, err |
There was a problem hiding this comment.
Suggested change
| return AuthResponse{}, err | |
| return AuthResponse{}, fmt.Errorf("build http request: %v", err) |
konnect/login_service.go
Outdated
| var authResponse AuthResponse | ||
| resp, err := s.client.Do(ctx, req, &authResponse) | ||
| if err != nil { | ||
| return AuthResponse{}, err |
There was a problem hiding this comment.
Suggested change
| return AuthResponse{}, err | |
| return AuthResponse{}, fmt.Errorf("authenticate http request: %v", err) |
| if err != nil { | ||
| return AuthResponse{}, err | ||
| } | ||
| url, _ := url.Parse(s.client.baseURL) |
konnect/login_service.go
Outdated
|
|
||
| info, err := s.UserInfo(ctx) | ||
| if err != nil { | ||
| return AuthResponse{}, err |
There was a problem hiding this comment.
Suggested change
| return AuthResponse{}, err | |
| return AuthResponse{}, fmt.Errorf("fetch user-info: %v", err) |
| @@ -78,6 +78,9 @@ func Get(ctx context.Context, fileContent *Content, opt RenderConfig, dumpConfig | |||
| builder.client = wsClient | |||
| builder.ctx = ctx | |||
| builder.skipCACerts = dumpConfig.SkipCACerts | |||
| if dumpConfig.KonnectRuntimeGroup != "" { | |||
| builder.disableDynamicDefaults = true | |||
cmd/ping.go
Outdated
| return fmt.Errorf("reading Kong version: %w", err) | ||
| } | ||
| fmt.Println("Successfully connected to Kong!") | ||
| fmt.Println("Kong version: ", version) |
There was a problem hiding this comment.
Can you break into two functions? pingKonnect and pingKong?
Please avoid long functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.