chore(file) refactor target config cert omission #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor the target config side of the --skip-ca-certificates implementation to use the dumpConfig setting inside file.Get() rather than stripping CA Certificates from target configuration afterwards.
Codecov Report
@@ Coverage Diff @@
## main #622 +/- ##
==========================================
+ Coverage 45.49% 45.53% +0.03%
==========================================
Files 74 74
Lines 8462 8462
==========================================
+ Hits 3850 3853 +3
+ Misses 4253 4250 -3
Partials 359 359
Continue to review full report at Codecov.
|
GGabriele
approved these changes
Mar 18, 2022
1 task
AntoineJac
pushed a commit
that referenced
this pull request
Jan 23, 2024
Refactor the target config side of the --skip-ca-certificates implementation to use the dumpConfig setting inside file.Get() rather than stripping CA Certificates from target configuration afterwards.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the target config side of the --skip-ca-certificates implementation to use the dumpConfig setting inside file.Get() rather than stripping CA Certificates from target configuration afterwards.
As-is we'd need to duplicate the logic to strip certificates out of target config downstream (see Kong/kubernetes-ingress-controller@3b926bd#diff-d8590e8687e7807da0cf97910b88e0ddbfc670866e0973a15c56597b99df9244R209-R214) which we don't want--it's simple, but it could potentially diverge. This allows us to use a single implementation internal to deck.